fix: treat at-rule names as case-insensitive across rules #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Aug 11, 2025
| @@ -42,7 +42,7 @@ export default { | |||
| const imports = new Set(); | |||
|
|
|||
| return { | |||
| "Atrule[name=import]"(node) { | |||
| "Atrule[name=/^import$/i]"(node) { | |||
There was a problem hiding this comment.
Can you also share the official reference where it is mentioned these are case insensitive?
There was a problem hiding this comment.
The at-rules affected in this PR are defined across different specs, so I’ll need to track down the relevant references. In the meantime, here’s a StackBlitz reproduction for @import.
|
CSS at-rules are case sensitive, so closing. |
|
@nzakas CSS at-rule names are case-insensitive. I tested each at-rule changed in this PR to confirm this before opening it. Here is a StackBlitz reproduction for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Ensure at-rule names are treated case-insensitively across rules, aligning with CSS syntax and preventing missed detections when authors use mixed-case at-rules.
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?